Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Various small simplifications #14695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 17, 2019
Merged

Various small simplifications #14695

merged 6 commits into from
Jul 17, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 4, 2019 •
edited
Loading

PR Summary

  • more check_in_list
  • remove unused import
  • more literal sets
  • more unpacking and star-unpacking

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the simplifications branch 3 times, most recently from 1333957 to 897eea0 Compare July 4, 2019 22:06
@QuLogic
Copy link
Member

QuLogic commented Jul 17, 2019

Conflicts...

@anntzer
Copy link
Contributor Author

anntzer commented Jul 17, 2019

rebased

QuLogic
QuLogic approved these changes Jul 17, 2019
View reviewed changes
lib/matplotlib/axes/_axes.py
@@ -2734,16 +2734,13 @@ def stem(self, *args, linefmt=None, markerfmt=None, basefmt=None, bottom=0,
raise TypeError('stem expected between 1 and 5 positional '
'arguments, got {}'.format(args))

y = np.asarray(args[0])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you need this asarray bit? I guess it's covered by convert_xunits?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes; in fact this change means that stem now correctly handles units on y-data (whereas they would be previously dropped by the call to asarray). Not an intentional change though :)

@anntzer anntzer mentioned this pull request Jul 17, 2019
Merged
6 tasks
@timhoffm timhoffm added this to the v3.2.0 milestone Jul 17, 2019
@timhoffm timhoffm merged commit 060d299 into matplotlib:master Jul 17, 2019
@anntzer anntzer deleted the simplifications branch July 17, 2019 18:25
@QuLogic QuLogic mentioned this pull request Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm