Add test and test-coverage to Makefile
#1470
Conversation
|
Wow, didn't even know there was a make file! I can't see any harm in adding these additions, though I guess a similar thing should be done for 👍 |
|
Before merging, I should probably update the developper documentation to mention the makefile. The two commands you mention here fail on my computer, with the traceback |
Nothing just yet. The "test" command is fairly standard in distribute and setuptools (http://packages.python.org/distribute/setuptools.html). The "check" command seems to be a standard thing and is defined for mpl's setup.py (as seen with HTH, |
|
I've added the commands to the documentation and the README. |
+1e100 |
|
|
||
| After installation, you can launch the test suite:: | ||
|
|
||
| $ make test |
There was a problem hiding this comment.
For me, this is not the preferred way of running the tests (in the same way the Makefile is not the preferred way of building the source).
I don't have a problem with adding the "test" makefile target, but I think I would prefer this line to be python tests.py.
|
Hi @NelleV : if adding a test / test-coverage target to the makefile makes things easier for some people to work with mpl, then I am all for that. My only concern (as indicated inline) is that it means there are two ways to run the tests, and therefore the documentation starts to say things like: "to run the tests, you can either do X or you can do Y." rather than "to run the tests, do X". For me, the latter is far clearer, as when I see a choice I wonder what the pros and cons of that choice are... Cheers, |
|
I can revert the changes in the documentation. I don't have a strong opinion on that. |
Perhaps just the changes to coding_guide.rst and removing the |
|
I've reverted those, and rebased master. |
|
@NelleV : Your patience with me is incredible - thank you and good stuff! 😄 |
Add ``test`` and ``test-coverage`` to Makefile
I run the tests very often, and I find it useful to have shortcuts in the makefile to run them. I've also added a shortcut to run the test coverage.
Thanks,
N