Correctly size non-ASCII characters in agg backend. #14705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
load_char does not resize the buffer, set_text does.
|
Also fixes #15576 |
jklymak
approved these changes
Oct 30, 2019
timhoffm
approved these changes
Oct 30, 2019
|
@meeseeksdev backport to v3.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 31, 2019
tacaswell
added a commit
that referenced
this pull request
Oct 31, 2019
…705-on-v3.2.x Backport PR #14705 on branch v3.2.x (Correctly size non-ASCII characters in agg backend.)
|
Is this fix available in 3.2.0rc2? I've installed it from pip install https://github.com/matplotlib/matplotlib/archive/v3.2.0rc2.tar.gz and am still hitting this bug version 3.1.0 with this manually applied fix worked! |
|
No, it is not in any tagged release. |
|
Rc2 seems to have itI opened it from https://github.com/matplotlib/matplotlib/tree/v3.2.0rc2/lib/matplotlib/backends Here is another link: https://github.com/matplotlib/matplotlib/blob/v3.2.0rc2/lib/matplotlib/backends/backend_agg.py#L183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load_char does not resize the buffer, set_text does.
Closes #8609
Need to think about whether this can be tested without a baseline image...Now has a test.
PR Summary
PR Checklist