Move the debug-mode TransformNode.write_graphviz out. #14725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only accessible by modifying the source of transforms.py to set
DEBUG to True (before the module is imported), and anyways broken
because transforms are not hashable in Py3 (so the call to hash()
fails).
Instead move it to a private module.
Example use:
Also, stop tracking transform node children even in debug mode, as it
was only used when dumping the transform but that's not even necessary
-- one can just inspect
vars(node)
to look for children.Also fix
AffineBase.__eq__
to check that the "other" object has aget_matrix method, to not raise an AttributeError when comparing with
Bboxes (which don't).
PR Summary
PR Checklist