Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate AxisArtist.dpi_transform. #14747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

Deprecate AxisArtist.dpi_transform. #14747

merged 1 commit into from
Apr 22, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 12, 2019

Figures already keep dpi_scale_trans correctly up-to-date; no need to
have additional code to keep a 1/72-scale version up-to-date as well.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.3.0 milestone Aug 24, 2019
QuLogic
QuLogic approved these changes Apr 22, 2020
View reviewed changes
@anntzer
Copy link
Contributor Author

anntzer commented Apr 22, 2020

rebased

jklymak
jklymak approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the doc errors real?

@anntzer
Deprecate AxisArtist.dpi_transform.
4eb5dde 
Figures already keep dpi_scale_trans correctly up-to-date; no need to
have additional code to keep a 1/72-scale version up-to-date as well.
@anntzer
Copy link
Contributor Author

anntzer commented Apr 22, 2020

yup, deprecation notice was in the wrong (old) place...

@QuLogic QuLogic merged commit d176508 into matplotlib:master Apr 22, 2020
@anntzer anntzer deleted the dpi_scale_trans branch April 22, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: mpl_toolkit
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @jklymak @tacaswell