Fix get_canvas_width_height() for pgf backend. #14749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
QuLogic
approved these changes
Jul 18, 2019
timhoffm
approved these changes
Jul 21, 2019
The pgf backend's get_canvas_width_height returns the canvas size in
inches, but it should return it in display units ("pixels", or
inches*dpi) instead.
get_canvas_width_height is actually barely used (only in text.py for
some backends (not pgf), in collections.py as an optimization, and in
BboxImage -- the only really relevant case), so to show the failure,
apply
diff --git i/examples/text_labels_and_annotations/demo_text_path.py w/examples/text_labels_and_annotations/demo_text_path.py
index 47ed5dd..d45a922f4 100644
--- i/examples/text_labels_and_annotations/demo_text_path.py
+++ w/examples/text_labels_and_annotations/demo_text_path.py
@@ -61,6 +61,7 @@ class PathClippedImagePatch(mpatches.PathPatch):
if __name__ == "__main__":
+ import matplotlib; matplotlib.use("pgf")
usetex = plt.rcParams["text.usetex"]
fig = plt.figure()
@@ -156,4 +157,5 @@ if __name__ == "__main__":
ax.set_xlim(0, 1)
ax.set_ylim(0, 1)
+ plt.savefig("/tmp/test.pdf")
plt.show()
and observe that the image is incorrectly drawn before the patch, but
correctly after.
|
added api changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pgf backend's get_canvas_width_height returns the canvas size in
inches, but it should return it in display units ("pixels", or
inches*dpi) instead.
get_canvas_width_height is actually barely used (only in text.py for
some backends (not pgf), in collections.py as an optimization, and in
BboxImage -- the only really relevant case), so to show the failure,
apply
and observe that the image is incorrectly drawn before the patch, but
correctly after.
before:
old.pdf
after:
new.pdf
PR Summary
PR Checklist