Thanks to visit codestin.com
Credit goes to github.com

Skip to content

for non-html output, let sphinx pick the best format (cherry-pick cha… #14788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

for non-html output, let sphinx pick the best format (cherry-pick cha… #14788

merged 1 commit into from
Oct 16, 2019

Conversation

jjcaballero
Copy link

…nge from pr-14683)

PR Summary

Changes taken from PR #14683 done by @anntzer
The goal is not to specify the image format for every sphinx builder allowing the usage of third-party builders (like confluence)
Now, with this PR I would really like, if possible, to count on those changes for python 2 too.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The CI failures are due to a change in CircleCI. We've fixed this by #14779. Can you please rebase so that we can see that CI passes. Thanks, and sorry for the additional effort, but the broken CI is beyond our influence.

@anntzer anntzer added this to the v2.2.5 milestone Jul 16, 2019
@tacaswell
Copy link
Member

@jjcaballero Given that you did this, I assume you need this change in a 2.2.x release (which I assume means you have a python27 enviroment)?

I'm going to try to run this through our normal back-port tools to make sure it ends up on the 3.1.x branch as well (as it would be very confusing to have it backported to the next 2.2.x release but not the next 3.1.x release!).

@jjcaballero
Copy link
Author

jjcaballero commented Jul 17, 2019 •
edited
Loading

@jjcaballero Given that you did this, I assume you need this change in a 2.2.x release (which I assume means you have a python27 enviroment)?

@tacaswell Yes, I have a python27 environment.

Will the normal back-port tools also do the job for the 2.2.x? Or for the 2.2.x this PR is ok?
I am asking because CI/checks are still failing. I am not sure if I should do something about it. Thanks

@tacaswell
Copy link
Member

Sorry for missing your question @jjcaballero ! I am going to re-base this and force-push to your branch in the next hour or so.

@tacaswell tacaswell force-pushed the v2.2.x-imageformatting branch from 61f6990 to 486b385 Compare October 15, 2019 20:42
@anntzer anntzer merged commit 58fede1 into matplotlib:v2.2.x Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: sphinx extension
Projects
None yet
Milestone
v2.2.5
Development

Successfully merging this pull request may close these issues.
4 participants
@jjcaballero @tacaswell @anntzer @timhoffm