Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: create a Agg figure without pyplot in buffer example #14797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2019
Merged

DOC: create a Agg figure without pyplot in buffer example #14797

merged 1 commit into from
Aug 13, 2019

Conversation

tacaswell
Copy link
Member

closes #14796

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.2.0 milestone Jul 16, 2019
@tacaswell tacaswell mentioned this pull request Jul 16, 2019
Closed
anntzer
anntzer reviewed Jul 16, 2019
View reviewed changes
timhoffm
timhoffm reviewed Jul 16, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the risk of being nitpicky is "agg figure" a real thing or just some slang? Maybe

draw a figure using agg

@tacaswell tacaswell force-pushed the doc_agg_buffer_example branch from 8438e21 to 6e00660 Compare July 17, 2019 02:47
anntzer
anntzer reviewed Jul 17, 2019
View reviewed changes
@tacaswell tacaswell force-pushed the doc_agg_buffer_example branch from 6e00660 to 719281b Compare July 17, 2019 13:32
@tacaswell
Copy link
Member Author

ok, third times the charm?

@anntzer
Copy link
Contributor

anntzer commented Jul 17, 2019

sure, but now you're really close to https://github.com/matplotlib/matplotlib/blob/master/examples/user_interfaces/canvasagg.py ... probably these should just be merged

dstansby
dstansby approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an improvement, so I'm going to merge

@dstansby dstansby merged commit bc76370 into matplotlib:master Aug 13, 2019
@tacaswell tacaswell deleted the doc_agg_buffer_example branch August 13, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer left review comments

@timhoffm timhoffm timhoffm left review comments

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

Show user how to use Agg buffer in example
4 participants
@tacaswell @anntzer @timhoffm @dstansby