Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify text_layout example. #14805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

Simplify text_layout example. #14805

merged 1 commit into from
Jul 16, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 16, 2019

By working with figure-level artists rather than axes-level ones (where
the axes cover the whole figure...) we don't have do specify the
transform again and again.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

jklymak
jklymak reviewed Jul 16, 2019
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but you probably need a bit of explanation why you are using fig.text otherwise, folks will wonder what that is, and be less likely to find ax.text?

@anntzer
Simplify text_layout example.
3224994 
By working with figure-level artists rather than axes-level ones (where
the axes cover the whole figure...) we don't have do specify the
transform again and again.
@anntzer
Copy link
Contributor Author

anntzer commented Jul 16, 2019

fair point, done

@jklymak jklymak merged commit 633a83c into matplotlib:master Jul 16, 2019
@jklymak jklymak added this to the v3.2.0 milestone Jul 16, 2019
@anntzer anntzer deleted the text_layout branch July 16, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Documentation topic: text
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @jklymak