Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve tkagg icon resolution #14849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Improve tkagg icon resolution #14849

merged 2 commits into from
Jul 22, 2019

Conversation

dstansby
Copy link
Member

Fixes #13891. This works locally for me, but someone else might know better, including:

  • What a .ppm file is, and why it was previously used over a .png file
  • Where docs for PhotoImage can be found, to check how far back .png support goes
  • What our minimum tk requirement is (I couldn't find it in our docs)

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't worry about any of these bullet points. When you search for old documents containing PhotoImage and png, you get at least back to the early 2000s.

The png is better. However, I assume 48x48 is not the end nowadays. We could make some larger icons at some point.

@dstansby
Copy link
Member Author

The travis failure is real; for some reason the OSX test doesn't like the image file, which is odd because it's working fine for me locally on macos.

@timhoffm
Copy link
Member

Maybe try making a new one using https://matplotlib.org/devdocs/gallery/misc/logos2.html and see if that's accepted?

@dstansby
Copy link
Member Author

Tried making a new one, if it works will have a think about the best way to organise the icons in the image folder.

@dstansby
Copy link
Member Author

To be safe I've just made a new .ppm file, and appended the resolution (128px square) to the filename which I think would be a good convention going forward.

@tacaswell tacaswell added this to the v3.2.0 milestone Jul 22, 2019
@tacaswell tacaswell merged commit c9edaed into matplotlib:master Jul 22, 2019
@dstansby dstansby deleted the tk-icon branch July 22, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blurry app icon on macOS
4 participants