Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated doc in images.py by adding direct link to 24-bit stink bug png #14896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2020
Merged

Updated doc in images.py by adding direct link to 24-bit stink bug png #14896

merged 1 commit into from
Jul 15, 2020

Conversation

majorwitty
Copy link
Contributor

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell changed the base branch from v3.1.1-doc to master July 26, 2019 18:09
@tacaswell
Copy link
Member

@majorwitty I changed the target of your PR to master. By targeting 3.1.1-doc you were trying to backport everything on master to that branch! We have a very helpful bot that backports individual PRs from master to the maintenance branches.

@tacaswell tacaswell added this to the v3.1-doc milestone Jul 26, 2019
@tacaswell
Copy link
Member

Thanks for this @majorwitty ! It looks good to me, but going to wait for CI to finish before merging.

timhoffm
timhoffm reviewed Jul 27, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is not parsed corretly.

https://23661-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/tutorials/introductory/images.html#sphx-glr-tutorials-introductory-images-py

Can links be multi-line in ReST?

@tacaswell tacaswell modified the milestones: v3.1-doc, 3.2-doc Mar 15, 2020
@timhoffm
Copy link
Member

timhoffm commented Jul 14, 2020 •
edited
Loading

Do we need an explicit link?

Options how to proceed:

  • Do nothing and close the issue.
  • Add a comment that the image can be downloaded via the context menu "Save image as"
  • Add a proper html download link via sphinx.. raw:: html.

@timhoffm
Copy link
Member

Related: #11296

@QuLogic
Copy link
Member

QuLogic commented Jul 15, 2020

The link just needed to end with `_. I pushed a rebase and added that.

@timhoffm timhoffm modified the milestones: 3.2-doc, v3.4.0 Jul 15, 2020
@timhoffm timhoffm merged commit 153813b into matplotlib:master Jul 15, 2020
@QuLogic QuLogic removed the status: needs comment/discussion needs consensus on next step label Jul 15, 2020
@tacaswell tacaswell mentioned this pull request Oct 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@majorwitty @tacaswell @timhoffm @QuLogic