Simplifications to errorbar(). #15037
Merged
+78
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3bb4485 to
856c6c4
Compare
856c6c4 to
35a298d
Compare
|
rebased |
timhoffm
reviewed
May 23, 2020
35a298d to
9c1c242
Compare
|
yup, handled. |
efiring
approved these changes
May 25, 2020
QuLogic
reviewed
May 26, 2020
- Move check that x and y have same size to top. - Replace xywhere by a more general mask-application function; then, in the various xlolims/xuplims/... handling blocks, apply all masks at once. - Apply xlolims/xuplims in extract_err, which allows drawing all errorbars in a single call to vlines()/hlines(). - We don't need to check the size of lolims/uplims because they go through broadcast() earlier. - Clarify the docstring a bit.
9c1c242 to
c24b1af
Compare
QuLogic
approved these changes
May 27, 2020
vlas-sokolov
pushed a commit
to vlas-sokolov/matplotlib
that referenced
this pull request
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the various xlolims/xuplims/... handling blocks, apply all masks at
once.
errorbars in a single call to vlines()/hlines().
through broadcast() earlier.
tbh, based on the somewhat debatable interpretation of lolims/uplims (should it be uplims/lolims? -- see docstring edit), the lack of anyone ever mentioning that, and the fact that their interpretation was inverted in #2452 with no apparent complaints, I believe it's likely that this feature (https://matplotlib.org/gallery/lines_bars_and_markers/errorbar_limits_simple.html) is extremely rarely used and may be worth shedding away, given the complexity of the implementation...
PR Summary
PR Checklist