Cleanup patheffects. #15072
Merged
Cleanup patheffects. #15072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify offset_transform to just return the additional translation that needs to be applied, creating a new transform as needed. - SimpleLineShadow does not need to specify fill_color -- draw_path defaults to None. - Fix an xfailing test: get_proxy_renderer was removed in 1.5; directly constructing the PathEffectRenderer is the replacement.
QuLogic
approved these changes
Aug 18, 2019
timhoffm
approved these changes
Aug 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that needs to be applied, creating a new transform as needed.
defaults to None.
constructing the PathEffectRenderer is the replacement.
PR Summary
PR Checklist