Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed app creation in qt5 backend (see #15100) #15122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2019
Merged

Fixed app creation in qt5 backend (see #15100) #15122

merged 1 commit into from
Aug 26, 2019

Conversation

macdems
Copy link
Contributor

@macdems macdems commented Aug 25, 2019

This PR changes type of argument of QApplication to str from bytes. See #15100 for discussion.

@timhoffm timhoffm added this to the v3.2.0 milestone Aug 25, 2019
@tacaswell tacaswell merged commit e2638a5 into matplotlib:master Aug 26, 2019
@tacaswell
Copy link
Member

Thanks @macdems ! Congratulations on your first Matplotlib contribution 🎉 Hopefully we will hear from you again!

Sorry the discussion got a bit contentious in #15100 .

@tacaswell tacaswell mentioned this pull request Aug 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@macdems @tacaswell @timhoffm