DOC: add example to power limit API change note #15137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this makes a visible change, should this not go in what's new instead of / as well as API changes? |
|
I see arguments either way, on one hand this changes appearance for the better in a particular domain so whats new, on the other hand, we treat default style changes as API changes. Maybe both? |
|
IMHO API changes is enough. "What's new" is for new features / capabilities. this is just a change of a default. But wouldn't object if somebody wants it in both. |
timhoffm
reviewed
Aug 27, 2019
Co-Authored-By: Tim Hoffmann <[email protected]>
6 tasks
timhoffm
approved these changes
Aug 28, 2019
|
Merging as is. If somebody feels a strong need for an additional "What's new" please open an additional PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.