Trivial style fixes. #15194
Merged
Trivial style fixes. #15194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the various test files, there is no point of wrapping checkdep_usetex in catch_warnings because checkdep_usetex uses logging.warning, not warnings.warn.
timhoffm
approved these changes
Sep 6, 2019
| return False | ||
| return np.isclose(-np.log(1/x-1), -np.log(1/y-1)) | ||
| return (np.isclose(-np.log(1/x-1), -np.log(1/y-1)) | ||
| if 0 < x < 1 and 0 < y < 1 else False) |
There was a problem hiding this comment.
Not convinced that the ternary if-else expression makes this more readable. But no strong feeling.
There was a problem hiding this comment.
It's not so much about the ternary, more about '0 < x < 1' vs 'x >= 1 or x <= 0', I can revert to non-ternary if you prefer.
There was a problem hiding this comment.
Fully agree on 0 < x < 1. Would slightly prefer non-ternary-if, but as said: no strong feelings.
There was a problem hiding this comment.
let's see what the next reviewer says, then
There was a problem hiding this comment.
It is fine this way. It is one less line of code, and one less return call.
WeatherGod
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the various test files, there is no point of wrapping checkdep_usetex
in catch_warnings because checkdep_usetex uses logging.warning, not
warnings.warn.
PR Summary
PR Checklist