Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix integers being passed as length to quiver3d. #15195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 6, 2019
Merged

Fix integers being passed as length to quiver3d. #15195

merged 3 commits into from
Sep 6, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 5, 2019

PR Summary

closes #15186.

As it turns out there was a subtle difference between linspace(0, length, num=2) and np.asarray([0, length]): the former always returns a float array...

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 5, 2019
@anntzer anntzer added this to the v3.1.2 milestone Sep 5, 2019
@tacaswell
Copy link
Member

I added a test and explicitly set the dtype rather than relying on implicitly picking up the float.

tacaswell
tacaswell approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I pushed 2 commits.

@timhoffm timhoffm merged commit 43f7f5a into matplotlib:master Sep 6, 2019
@lumberbot-app
Copy link

lumberbot-app bot commented Sep 6, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 43f7f5aa71052cb69057725c67850d99b7fe9cd2
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #15195: Fix integers being passed as length to quiver3d.'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-15195-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #15195 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the quiver3d-int branch September 6, 2019 08:59
@tacaswell tacaswell modified the milestones: v3.1.2, v3.2.0 Feb 16, 2020
@tacaswell
Copy link
Member

this did not get backported for v3.1.2 or v3.1.3 but is included in v3.2.0, re milestoned to match that.

@tacaswell tacaswell removed status: needs manual backport Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Feb 17, 2020
@QuLogic
Copy link
Member

QuLogic commented Feb 19, 2020

But the backport of this PR didn't happen for 3.2.0 either?

@tacaswell
Copy link
Member

This got merged before we branched. The commit claims to be in the rcs

@QuLogic
Copy link
Member

QuLogic commented Feb 20, 2020

Oh yes, I hadn't realized this was so old. It is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

3D quiver plot fails when pivot = "middle"
5 participants
@anntzer @tacaswell @QuLogic @timhoffm @dstansby