Force html4 writer for sphinx 2 #15196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please give a little more context? Does the patch fix all sphinx 2 issues? Do we want/need a strategy to migrate to html5 later on? |
|
Sorry, have updated the original comment above. I've also re-targeted this to |
NelleV
approved these changes
Sep 7, 2019
|
Thanks @dstansby ! |
|
It is on master and we haven't branched yet (probably tonight) so it will be in 3.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx 2 by default uses a
html5writer, that changes the outputted html, causing the issues mentioned in #13591. In order to allow the use of sphinx 2, without having to change our CSS, makes sphinx 2 use thehtml4writer that sphinx 1 also uses.Possibly we will want to migrate/upgrade to the
html5writer, but changing the CSS to match is a pain (see #14105 for my aborted attempt to do this) so this provides a solution to use sphinx 2 in the medium term.Fixes #13591