DOC: github ribbon does not cover up index link #1523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks @jenshnielsen for spotting the fact that the previous "solution" didn't actually work as intended.
|
Thanks. +1 |
|
Thanks @ivanov. |
dmcdougall
added a commit
that referenced
this pull request
Nov 26, 2012
DOC: github ribbon does not cover up index link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks to @jenshnielsen for spotting the fact that the previous "solution"
didn't actually work as intended in #1474. This PR fixes the issue of the ribbon covering up links under it.
Before this commit, hovering over the word "index" did not activate the link, and the ribbon looked like this:
Now, the ribbon has moved, and hovering over "index" works as intended.
Also, I've given a title to the GitHub ribbon link, so hovering over it also displays a little tooltip, like so
