backend_ps cleanup. #15233
Merged
backend_ps cleanup. #15233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Feb 16, 2020
1420e27 to
f4d742f
Compare
QuLogic
reviewed
Mar 10, 2020
| @@ -1006,28 +985,18 @@ def print_figure_impl(fh): | |||
|
|
|||
| @cbook._delete_parameter("3.2", "dryrun") | |||
| def _print_figure_tex( | |||
| self, outfile, format, dpi, facecolor, edgecolor, | |||
| orientation, papertype, *, | |||
| metadata=None, dryrun=False, bbox_inches_restore=None, **kwargs): | |||
There was a problem hiding this comment.
So this function is technically private, but we still have _delete_parameter on it, so is it really safe to be deleting other parameters here?
There was a problem hiding this comment.
The _delete_parameter is there because previously it couldn't go onto the public caller (print_ps) which just accepted dryrun into kwargs (xref #16231).
print_ps only ever passes facecolor/edgecolor as kwargs anyways, so they would get silently absorbed into kwargs.
|
rebased |
Dedupe some code between backend_ps and backend_bases (the edgecolor and
facecolor handling -- see changelog), as well as between the non-tex and
tex cases (by formatting the header metadata ("dsc_comments") earlier).
Also simplify a bit papersize handling in usetex case.
QuLogic
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedupe some code between backend_ps and backend_bases (the edgecolor and
facecolor handling -- see changelog), as well as between the non-tex and
tex cases (by formatting the header metadata ("dsc_comments") earlier).
PR Summary
PR Checklist