Change layout of test_triager to avoid cropping images. #15261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous test triager would crop test images because the 800/500 aspect ratio of the main widget does not match the 6.4:4.8 aspect ratio of the test images. Change the main widget to have size 800x600, and move the thumbnails to the side so that the whole thing still fits in a 1600x900 display.
timhoffm
approved these changes
Sep 12, 2019
|
This has been annoying me for a while, but not enough to do something about it, thanks @anntzer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous test triager would crop test images because the 800/500
aspect ratio of the main widget does not match the 6.4:4.8 aspect ratio
of the test images. Change the main widget to have size 800x600, and
move the thumbnails to the side so that the whole thing still fits in a
1600x900 display.
before
after
(yes, this is the whole test image, the ylabels are actually cropped)
PR Summary
PR Checklist