Embedding in Tk example: Fix toolbar being clipped. #15266
Conversation
|
The |
Calling `pack` without options puts the widget at the end of the package list. Space is allocated to widgets sequentially. If a window is too small, there may be no space left for widgets. By packing the canvas last, we essentially give the toolbar and the quit button priority in the packing order. Fixes matplotlib#13485.
335eff2 to
350c50a
Compare
|
Oops, didn't even notice the button. I would argue that any UI controls should be displayed as long as possible, because the canvas is rather flexible in size. After re-reading the tk docs: calling The question is, what is the priority of the UI controls in this example? Creating a toolbar implicitly packs it, so to keep the example simple I think it is okay if the order goes:
|
There was a problem hiding this comment.
The "embedding in tk" example is very important; for many it's the number one resource for understanding how to use matplotlib in GUIs. It's hence important to keep this example clean and working.
Thanks very much @jmehne for this update of it.
…266-on-v3.2.x Backport PR #15266 on branch v3.2.x (Embedding in Tk example: Fix toolbar being clipped.)
Fixes #13485.
This was driving me crazy, but #13485 pointed me to the right code in mpl where it actually works, and it has this helpful comment there:
So, the solution is to pack the canvas after the toolbar got initialized, because initializing the toolbar will call
packon the root window.Flake 8 passes, the other points don't apply, but correct me if I'm wrong :)
PR Summary
PR Checklist