Colorbar cleanup.#15282
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Sep 18, 2019
Merged
Conversation
jklymak
approved these changes
Sep 17, 2019
| if self._use_auto_colorbar_locator(): | ||
| _log.debug('Using auto colorbar locator on colorbar') | ||
| _log.debug('locator: %r', locator) | ||
| _log.debug('Using auto colorbar locator %r on colorbar', locator) |
Member
There was a problem hiding this comment.
I put this in as a debugging step at some point I think. Not sure what our policy is vis-a-vis lots of debugs, so feel free to remove it if its too crufty.
Contributor
Author
There was a problem hiding this comment.
I think leaving one log line is fine.
timhoffm
approved these changes
Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
mostly removing explicit rst roles from docs; tiny refactorings as well.
PR Checklist