@timhoffm Could you have a look at this. I think the failures are unrelated to the PR

Thanks!

@timhoffm Thanks for helping.
I am not able to understand why setting category in _warn_deprecated is one level deeper than _warn_external. Isn't _warn_deprecated one level higher abstraction than _warn_external?.
Or did I understand you wrong?:sweat_smile:

Sorry to have caused confusion. Yes, you are right, this is actually one level higher.

Anyway, the point is warn_deprecated should call _warn_external(warning, category=MatplotlibDeprecationWarning).

@timhoffm I think I have made a mistake while squashing the commits, could you have a look please and let me know what needs to be done. Thanks!

You've apparently accidentially squashed some of your changes with an existing commit from master (a371ae4).

It's probably the most easy to start a new branch on top of current master. This is how I would do it (but there are many ways in git):

1. Copy your 2018-09-18-AL.rst somewhere safe.
2. git checkout master, git pull ustream master
3. Remove the branch git branch -D cbook_warning
4. Recreate the branch on top of master git checkout -b cbook_warning
5. Cherry-pick your valid commit git cherry-pick b29a9db.
6. Copy 2018-09-18-AL.rst back and amend your existing commit: git add 2018-09-18-AL.rst and git commit --amend --no-edit.
7. Then force push git push origin cbook_warning --force

@timhoffm Thanks a lot for the detailed explanation and steps! 😄