Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix tooltip display bug #15387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2020
Merged

Conversation

dorafc
Copy link
Contributor

@dorafc dorafc commented Oct 7, 2019

Updated CSS to fix an issue with the tooltip being cutoff by the
edge of the content. This change is dependent on updates to sphinx
gallery. This will also require a sphinx gallery version bump after the new version is released (otherwise there will be block of extra white space on the page)

requires sphinx-gallery/sphinx-gallery#543

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@timhoffm
Copy link
Member

sphinx-gallery/sphinx-gallery#543 has been included in sphinx-gallery 0.5. IMHO we should bump our dependency and move this forward.

@tacaswell tacaswell added this to the 3.2-doc milestone Mar 28, 2020
dorafc added 2 commits March 28, 2020 15:38
Updated CSS to fix an issue with the tooltip being cutoff by the
edge of the content. This change is dependent on updates to sphinx
gallery.
This is the lowest version that has the CSS bug fix
@dorafc dorafc force-pushed the fix_tooltip_display_bug branch from a079333 to ef82f81 Compare March 28, 2020 19:40
@tacaswell tacaswell merged commit 160f8ad into matplotlib:master Mar 29, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Mar 29, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.1-doc
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 160f8ad054eb674206aa60cf3a95b0803da4f576
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #15387: fix tooltip display bug'
  1. Push to a named branch :
git push YOURFORK v3.2.1-doc:auto-backport-of-pr-15387-on-v3.2.1-doc
  1. Create a PR against branch v3.2.1-doc, I would have named this PR:

"Backport PR #15387 on branch v3.2.1-doc"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Mar 30, 2020
Merge pull request matplotlib#15387 from dorafc/fix_tooltip_display_bug

DOC: fix tooltip display bug
QuLogic added a commit that referenced this pull request Mar 30, 2020
…-v3.2.1-doc

Backport PR #15387: fix tooltip display bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants