Fix invalid checks for axes_class parameter in ImageGrid. #15461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
flake8: |
The validation of the axes_class parameter in the Grid and ImageGrid class have been wrong ever since they were merged in in f44235e (relevant followup commits: 7482fdc, a5e67b9). - In Grid, self._defaultAxesClass has never been a class with its own .Axes attribute, so the subclass check would fail with an AttributeError. - In ImageGrid, the `isinstance(axes_class, Axes)` check should be `issubclass(...)` instead. (The code later calls `axes_class(...)` to build an axes instance so if one really passed an axes instance, the call would raise an exception as axes are not callable.) Fix these checks. As a consequence, there was no previously valid path where axes_class_args would have been set, and passing a `(class, args)` pair is not documented anyways, so drop that "functionality" (which never worked).
|
thanks, fixed |
a5922c8 to
22b614b
Compare
timhoffm
approved these changes
Oct 22, 2019
dstansby
approved these changes
Nov 9, 2019
|
This did used to work and is used in the cartopy documentation (https://scitools.org.uk/cartopy/docs/latest/gallery/axes_grid_basic.html) so we should put it back, I will have a PR open shortly. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation of the axes_class parameter in the Grid and ImageGrid
class have been wrong ever since they were merged in in f44235e
(relevant followup commits: 7482fdc, a5e67b9).
.Axes attribute, so the subclass check would fail with an
AttributeError.
isinstance(axes_class, Axes)check should beissubclass(...)instead. (The code later callsaxes_class(...)to build an axes instance so if one really passed an axes instance,
the call would raise an exception as axes are not callable.)
Fix these checks. As a consequence, there was no previously valid
path where axes_class_args would have been set, and passing a
(class, args)pair is not documented anyways, so drop that"functionality" (which never worked).
PR Summary
PR Checklist