Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cleanup axisartist tutorial. #15505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2019
Merged

Cleanup axisartist tutorial. #15505

merged 1 commit into from
Oct 25, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Oct 24, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm reviewed Oct 24, 2019
View reviewed changes
tutorials/toolkits/axisartist.py
@@ -541,7 +541,7 @@ def inv_tr(x, y):
# system in degree
tr = Affine2D().scale(np.pi/180., 1.) + PolarAxes.PolarTransform()

# extreme finder : find a range of coordinate.
# extreme finder: find a range of coordinate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not change this one occurence. There seems to be some consistency in having a space before the colon throughout the tutorial. Either change all or none.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they're all changed now to no space (double colons at end of paragraphs introducing code blocks don't show up in the rendered html so are irrelevant here).

timhoffm
timhoffm approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anybody can merge after CI pass.

@dstansby dstansby merged commit fadc7fc into matplotlib:master Oct 25, 2019
@dstansby
Copy link
Member

Anybody can merge after CI pass.

An offer I can't refuse!

@QuLogic QuLogic added this to the v3.3.0 milestone Oct 25, 2019
@anntzer anntzer deleted the axisartist-tut branch October 26, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation topic: mpl_toolkit
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dstansby @timhoffm @QuLogic