Remove matplotlib.sphinxext.tests from __init__.py #15579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following commit: 291599d moved tests in sphinxext to matplotlib/tests but missed removing matplotlib.sphinxext.tests from matplotlib/__init__.py. This does not seem to affect testing using pytest directly, but fails when invoked using tests.py.
anntzer
approved these changes
Oct 31, 2019
tacaswell
approved these changes
Nov 1, 2019
|
Should probably wait on code-cov on this one. |
|
Thanks @siddhesh ! |
|
Travis has passed completely. Don't know why it's still displayed as pending on github. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 1, 2019
timhoffm
added a commit
that referenced
this pull request
Nov 1, 2019
…579-on-v3.2.x Backport PR #15579 on branch v3.2.x (Remove matplotlib.sphinxext.tests from __init__.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Commit: 291599d
moved tests in
sphinxexttomatplotlib/testsbut missed removingmatplotlib.sphinxext.testsfrommatplotlib/__init__.py. This does notseem to affect testing using pytest directly, but fails when invoked
using tests.py.
PR Checklist