Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove FAQ on 'Search' -- already referenced in search file #15591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

jakeprojects
Copy link
Contributor

PR Summary

PR Checklist

  • Documentation is sphinx and numpydoc compliant

@tacaswell
Copy link
Member

Thanks for this @jakeprojects !

I agree that having it in two places may be too much, but I think a bit more of the context from the FAQ should survive and we need to sort out why the docs build is failing (you can click through to download the logs). My suspicion is that there as a reference to that FAQ entry someplace which is now broken.

@tacaswell tacaswell added this to the v3.3.0 milestone Nov 3, 2019
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more of the content from the FAQ paragraph should survive and the docs need to build clean.

Anyone can dismiss this.

@anntzer
Copy link
Contributor

anntzer commented Nov 12, 2019

Discussion during call was that having that info at the bottom of the FAQ is probably not that useful; in fact anyone you do a search this already shows up at the top of the search page where many more people are going to see that; hence, dismissing @tacaswell's request-for-changes.
The doc build does still need to be fixed, though.

@timhoffm
Copy link
Member

I've added a commit to fix the missing link. Please squash when merging (I didn't want to force-push to a foreign fork).

@anntzer anntzer merged commit 70fb1a6 into matplotlib:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants