TST: Increase tolerance of some tests for aarch64 #15620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Nov 7, 2019
Some tests differ from expected result on aarch64 by more than the expected tolerance. The generated images however remain visually similar. The differences appear to be at borders of colours for images, i.e. edges of fonts, between transitions of colours, etc. and is possibly due to FP rounding differences at those points. Bump up tolerance of these tests by a wee bit so that they pass on aarch64.
dopplershift
approved these changes
Nov 7, 2019
|
Thanks @siddhesh ! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 7, 2019
QuLogic
added a commit
that referenced
this pull request
Nov 8, 2019
…620-on-v3.2.x Backport PR #15620 on branch v3.2.x (TST: Increase tolerance of some tests for aarch64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Some tests differ from expected result on aarch64 by more than the
expected tolerance. The generated images however remain visually
similar.
The differences appear to be at borders of colours for images,
i.e. edges of fonts, between transitions of colours, etc. and is
possibly due to FP rounding differences at those points.
Bump up tolerance of these tests by a bit so that they pass on
aarch64.
PR Checklist