-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Cleanup dates.py docstrings. #15683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup dates.py docstrings. #15683
Conversation
30acd31
to
6970f9e
Compare
""" | ||
Parameters | ||
---------- | ||
tz : `tzinfo` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe: "Specify the timezone for the ticks".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, had only fixed one of the occurrences, now the second one is good too.
ticks (ticking every other, every 3, etc.). For fine-grained | ||
control, this can be a dictionary mapping individual rrule | ||
frequency constants (YEARLY, MONTHLY, etc.) to their own maximum | ||
number of ticks. This can be used to keep the number of ticks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you reference intervald
above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh it's not clear to me how intervald interacts with minticks, maxticks, and interval_multiples, so I'll pass on that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks really helpful. Just a few minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone can merge when CI passes
…683-on-v3.2.x Backport PR #15683 on branch v3.2.x (Cleanup dates.py docstrings.)
PR Summary
PR Checklist