Templatize spectral helpers. #15719
Merged
Templatize spectral helpers. #15719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Dec 22, 2019
I think the repetition is large enough to be worth it. This does make these functions all refer to themselves as well in the See Also section, but that seems benign enough.
06c2ad0 to
a226f82
Compare
|
done |
timhoffm
approved these changes
Dec 23, 2019
jklymak
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the repetition is large enough to be worth it. This does make
these functions all refer to themselves as well in the See Also section,
but that seems benign enough.
PR Summary
PR Checklist