Cleanup some mplot3d docstrings. #15735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove comment about method not being tested for methods that
actually do get test coverage.
- Rewrite set_{x,y,z}scale docstring -- we don't actually support any
scale other than linear, and the comment about "improving with each
release" has clearly been untrue. Also remove versionadded note: the
methods existed before 1.1.0, they were just inherited from the base
class, and it wasn't better or worse before...
- Remove versionadded for get_frame_on and set_frame_on, which existed
even before 1.1.0 (likewise inherited from the base Axes, which has
the same implementation; the only difference is the docs).
- Remove comment about fix in future releases in tick_params -- that's
not different from any other part of the API, and has in fact been
left unfixed for years.
- Remove duplicate versionadded info for plot_trisurf.
dstansby
approved these changes
Nov 22, 2019
timhoffm
approved these changes
Nov 22, 2019
|
@meeseeksdev backport to v3.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 25, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 25, 2019
QuLogic
added a commit
that referenced
this pull request
Dec 25, 2019
…735-on-v3.1.x Backport PR #15735 on branch v3.1.x (Cleanup some mplot3d docstrings.)
QuLogic
added a commit
that referenced
this pull request
Dec 25, 2019
…735-on-v3.2.x Backport PR #15735 on branch v3.2.x (Cleanup some mplot3d docstrings.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actually do get test coverage.
scale other than linear, and the comment about "improving with each
release" has clearly been untrue. Also remove versionadded note: the
methods existed before 1.1.0, they were just inherited from the base
class, and it wasn't better or worse before...
even before 1.1.0 (likewise inherited from the base Axes, which has
the same implementation; the only difference is the docs).
not different from any other part of the API, and has in fact been
left unfixed for years.
PR Summary
PR Checklist