Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix env override in WebAgg backend test. #15737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2019
Merged

Fix env override in WebAgg backend test. #15737

merged 1 commit into from
Nov 20, 2019

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Nov 20, 2019

It's only necessary to override DISPLAY, not throw away the rest of the environment. Without the other environment variables, stuff like custom PYTHONPATH break in this test.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic
Fix env override in WebAgg backend test.
f0dbd8d 
It's only necessary to override DISPLAY, not throw away the rest of the
environment. Without the other environment variables, stuff like custom
PYTHONPATH break in this test.
@QuLogic QuLogic added this to the v3.2.0 milestone Nov 20, 2019
@anntzer anntzer merged commit 1eacd31 into matplotlib:master Nov 20, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 21, 2019
@anntzer
Backport PR matplotlib#15737: Fix env override in WebAgg backend test.
f77dcda
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 21, 2019
Merged
@QuLogic QuLogic deleted the fix-webagg-test-env branch November 21, 2019 00:01
@tacaswell
Copy link
Member

🐑 Sorry for applying too big of a hammer.

tacaswell added a commit that referenced this pull request Nov 21, 2019
@tacaswell
Merge pull request #15738 from meeseeksmachine/auto-backport-of-pr-15…
02ac55c 
…737-on-v3.2.x

Backport PR #15737 on branch v3.2.x (Fix env override in WebAgg backend test.)
@tacaswell
Copy link
Member

@meeseeksdev backport to v3.1.x

@meeseeksmachine meeseeksmachine mentioned this pull request Dec 6, 2019
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 6, 2019
@anntzer
Backport PR matplotlib#15737: Fix env override in WebAgg backend test.
1accf54
tacaswell added a commit that referenced this pull request Dec 6, 2019
@tacaswell
Merge pull request #15843 from meeseeksmachine/auto-backport-of-pr-15…
42e257e 
…737-on-v3.1.x

Backport PR #15737 on branch v3.1.x (Fix env override in WebAgg backend test.)
@QuLogic QuLogic modified the milestones: v3.2.0, v3.1.3 Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: webagg topic: testing
Projects
None yet
Milestone
v3.1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @tacaswell @anntzer @timhoffm