Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Document doc style for default values #15824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2019

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Dec 3, 2019

PR Summary

As discussed in the dev call: Document how we want to document default values.

@timhoffm timhoffm added this to the v3.2.1 milestone Dec 3, 2019
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for a second review as it's a policy change, not a doc change.

Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 modulo the minor grammar changes.

@timhoffm timhoffm force-pushed the writing-doc-default branch from 3083a89 to 2152551 Compare December 5, 2019 18:59
@timhoffm timhoffm dismissed story645’s stale review December 7, 2019 17:39

Requested changes adressed.

@story645
Copy link
Member

story645 commented Dec 8, 2019

Thanks for making the changes!

@timhoffm timhoffm deleted the writing-doc-default branch December 8, 2019 07:11
timhoffm added a commit that referenced this pull request Dec 8, 2019
…824-on-v3.2.x

Backport PR #15824 on branch v3.2.x (Document doc style for default values)
@timhoffm timhoffm modified the milestones: v3.2.1, v3.2.0 Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants