Fix Annotation using different units and different coords on x/y. #15886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this get a test that shows it closes the bug? |
`_get_xy` always needs to be called with self.xycoord, not just the coordinate system of either x or y, so that unitful x/y get correctly converted as needed.
6856ea5 to
bd21ebd
Compare
|
sure... |
jklymak
approved these changes
Dec 12, 2019
timhoffm
approved these changes
Dec 20, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Dec 20, 2019
…d different coords on x/y.
timhoffm
added a commit
that referenced
this pull request
Dec 22, 2019
…886-on-v3.2.x Backport PR #15886 on branch v3.2.x (Fix Annotation using different units and different coords on x/y.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_get_xyalways needs to be called with self.xycoord, not just thecoordinate system of either x or y, so that unitful x/y get correctly
converted as needed.
Closes #15849.
PR Summary
PR Checklist