Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Correctly handle non-affine transData in Collection.get_datalim. #15903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2019
Merged

Correctly handle non-affine transData in Collection.get_datalim. #15903

merged 1 commit into from
Dec 12, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 10, 2019

See comments.

Closes #15806 (@QuLogic can you confirm?). Sorry, no tests, but I think the patch makes sense...

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Dec 10, 2019
@anntzer anntzer added this to the v3.2.0 milestone Dec 10, 2019
jklymak
jklymak approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, but not sure if it fixes the cartopy issue.

tacaswell
tacaswell approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test would be better, but @anntzer reports that this fixes cartopy and this does not break any of our tests.

@tacaswell tacaswell requested a review from QuLogic December 10, 2019 20:35
QuLogic
QuLogic approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes Cartopy for me as well.

@jklymak jklymak merged commit f8a9a49 into matplotlib:master Dec 12, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 12, 2019
@jklymak
Backport PR matplotlib#15903: Correctly handle non-affine transData i…
c1f6dbf 
…n Collection.get_datalim.
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 12, 2019
Merged
@anntzer anntzer deleted the nonaffine-transdata branch December 12, 2019 08:20
tacaswell added a commit that referenced this pull request Dec 12, 2019
@tacaswell
Merge pull request #15915 from meeseeksmachine/auto-backport-of-pr-15…
ad65e98 
…903-on-v3.2.x

Backport PR #15903 on branch v3.2.x (Correctly handle non-affine transData in Collection.get_datalim.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

3.2.0 may break some Cartopy tests
4 participants
@anntzer @tacaswell @QuLogic @jklymak