Refactor Annotation properties. #15988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Feb 16, 2020
- Make xycoords a property to validate inputs at set-time, rather than at draw time. - First define get_anncoords and set_anncoords, and then the anncoords property from them (the dance is just so that anncoords and get_anncoords get different docstrings...) as that order avoids having to fiddle with fget and fset.
timhoffm
approved these changes
Feb 16, 2020
QuLogic
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at draw time.
property from them (the dance is just so that anncoords and
get_anncoords get different docstrings...) as that order avoids having
to fiddle with fget and fset.
PR Summary
PR Checklist