Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid using np.matrix. #15992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2019
Merged

Avoid using np.matrix. #15992

merged 2 commits into from
Dec 22, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 20, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

jklymak
jklymak reviewed Dec 21, 2019
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to know if you made any mistakes or not if this section is not tested...

@anntzer
Copy link
Contributor Author

anntzer commented Dec 21, 2019 •
edited
Loading

This is tested via examples/axes_grid1/demo_axes_hbox_divider.py (and likely a few other examples). Yes, it would be better if axes_grid1 had better test coverage, but that'd be a bigger project...

@dopplershift
Copy link
Contributor

@anntzer How hard would it be to turn one of those examples into an image test? (I don't want to hold this up for that.)

@anntzer
Copy link
Contributor Author

anntzer commented Dec 22, 2019

Added a non-image-comparison test.

dopplershift
dopplershift approved these changes Dec 22, 2019
View reviewed changes
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test. I feel much better knowing it's less likely we've broken a less-used corner of the library.

@dopplershift dopplershift merged commit 1d6cc11 into matplotlib:master Dec 22, 2019
@anntzer anntzer deleted the matless branch December 23, 2019 10:07
@QuLogic QuLogic added this to the v3.3.0 milestone Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: mpl_toolkit
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @dopplershift @jklymak @timhoffm @QuLogic