Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prevent FigureCanvasQT_draw_idle recursively calling itself. #16028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2019
Merged

Prevent FigureCanvasQT_draw_idle recursively calling itself. #16028

merged 1 commit into from
Dec 29, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 26, 2019

Avoids an infinite loop in examples/event_handling/path_editor.py.

The logic is now similar to the one before 984fba1 (see 984fba1#diff-24fdb85343951b7d9bd270c47d6abe8fL154, not sure why I had changed that; mplcairo also works fine with the patch).

Closes #15481, AFAICT. attn @timhoffm, @QuLogic.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Prevent FigureCanvasQT_draw_idle recursively calling itself.
7a51cac 
Avoids an infinite loop in examples/event_handling/path_editor.py.

The logic is now similar to the one before 984fba1.
@Kojoley Kojoley added this to the v3.1.3 milestone Dec 29, 2019
@Kojoley Kojoley merged commit 9984f9c into matplotlib:master Dec 29, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 29, 2019
@Kojoley @meeseeksmachine
Backport PR matplotlib#16028: Prevent FigureCanvasQT_draw_idle recurs…
e6ffa5d 
…ively calling itself.
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 29, 2019
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 29, 2019
@Kojoley @meeseeksmachine
Backport PR matplotlib#16028: Prevent FigureCanvasQT_draw_idle recurs…
7764fda 
…ively calling itself.
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 29, 2019
Merged
@anntzer anntzer deleted the qtrecursivedraw branch December 29, 2019 20:06
QuLogic added a commit that referenced this pull request Dec 30, 2019
@QuLogic
Merge pull request #16032 from meeseeksmachine/auto-backport-of-pr-16…
787fcce 
…028-on-v3.1.x

Backport PR #16028 on branch v3.1.x (Prevent FigureCanvasQT_draw_idle recursively calling itself.)
QuLogic added a commit that referenced this pull request Dec 30, 2019
@QuLogic
Merge pull request #16033 from meeseeksmachine/auto-backport-of-pr-16…
92da21c 
…028-on-v3.2.x

Backport PR #16028 on branch v3.2.x (Prevent FigureCanvasQT_draw_idle recursively calling itself.)
@larsoner larsoner mentioned this pull request Jan 22, 2020
Closed
@anntzer anntzer mentioned this pull request Jan 23, 2020
Merged
6 tasks
@ImportanceOfBeingErnest ImportanceOfBeingErnest mentioned this pull request May 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: Qt
Projects
None yet
Milestone
v3.1.3
Development

Successfully merging this pull request may close these issues.

Recursion error
3 participants
@anntzer @timhoffm @Kojoley