-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Nicer formatting of community aspects on front page #16065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e92904e
to
ecd66fe
Compare
I like the idea of this, and I think it's fantastic for guiding the eye, but I think the organization is tangling the external resources up with the internal ones (and yes that was happening in the original docs but this layout exacerbates the issue, and there's probably a different way to describe than internal/external but they're categorically different): External
Internal:
Also, how much weight do we want to give to stack overflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left feedback in comment 'cause easier to do based on screen shot
@story645 I think stack overflow is fabulous and really is where folks should start a search. Pointing people to the tag is super helpful. |
@jklymak I agree it's helpful (@ImportanceOfBeingErnest's answers are basically how I made something the other day), but the mpl dev team has no control over the site - which means its harder to response to answers that are not current, accurate, or best practice , and on a community site we have no control over interactions and so is notorious for feeling unwelcoming to coders from underrepresented groups. I'm not saying we shouldn't link to it, just that I dunno if we want to recommend it as the first stop. |
@story645 Thanks for the feedback. I was hoping not to go into the details of the contents too much with this PR, and therefore took the bullet points as is 😎. I agree that this is not the final state we want the website to be in, it's only a visual improvement not much a content improvement. IMHO already that step is worth it - I'm really turned off buy the bulky text when opening the webpage. I'm fine if we can replace this with something even better soon. Content is a much larger discussion. IMHO in the end, we do not want to just display resources, but structure by actions (Install, get help, discuss, report a bug, view news, ...). These are not 1:1 correlated to the resources. I'm not worried too much about internal vs. external resources; for the average user it does not matter too much if he gets help from the docs, discourse or stackoverflow. My motivation for there given order was:
If you have any suggestions how to improve the order or other small things, I'm happy to include these. Let's go incremental. -> Is this better than before? |
So my issue is that I don't think it's better than before because to me this visual layout gives me an expectation for where the links should be and that's making it harder for me to find the information. That's why in this change I really don't think we can seperate content from layout. As a first pass, I either suggest the delineation I proposed in my comment above or using some kind of visual cue - different sections/borders/headers to make your proposed organization clearer. |
Strongly agree that the icons should be links! Otherwise, I think this is an improvement while more work is done in the future. |
@timhoffm I love the sectioning, thank you! And I agree with putting all the mailing lists under dev since an end goal is to retire them in favor of discourse. |
8692156
to
9b9a9fd
Compare
My only concern about this is that its massive on mobile. Not that our man page is particularly responsive on mobile (though it should be). |
For reference: docs from CI Responsive design would be nice, but it is second priority compared to having a good index page at all. I assume we get very little traffic from mobile (actually, do we have stats?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an improvement...
9b9a9fd
to
640bed0
Compare
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
…065-on-v3.2.x Backport PR #16065 on branch v3.2.x (Nicer formatting of community aspects on front page)
Skipping backporting to 3.1.x. Hoping that 3.2.0 will get out some time soon. |
…v2.2.x Backport PR #16065 on branch v2.2.x (Nicer formatting of community aspects on front page)
DOC: Nicer formatting of community aspects on front page Conflicts: doc/index.rst Deleted the final paragraph about GH to match all other branches.
Backported to v3.1.x as 1607430 as we are doing a 3.1.3 release. |
PR Summary
A step towards a more welcoming homepage. Hopefully more visually pleasing and less intimidating than the current block of text https://matplotlib.org/. The content is the same apart from minor wording changes.
Preview:Preview new