Cleanup category.py docstrings. #16072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
story645
approved these changes
Jan 2, 2020
|
AnyStr seems pretty obscure though. Unless there is some reason to steer people to byte strings is there any reason to be precise about the docstring? |
|
I'm fine either way. (Or we can go for |
timhoffm
reviewed
Jan 2, 2020
For the better or (mostly) the worst, we support both bytes and str. AnyStr is the union of both of them (per stdlib typing).
|
went with @timhoffm's suggestion |
timhoffm
approved these changes
Jan 2, 2020
|
Waiting to see if there are objections. Otherwise can self-merge after a day or so. |
jklymak
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
For the better or (mostly) the worst, we support both bytes and str.
AnyStr is the union of both of them (per stdlib typing).
PR Checklist