Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use C++ true/false in ttconv. #16088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

Use C++ true/false in ttconv. #16088

merged 1 commit into from
Jan 4, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 4, 2020

Not much to it, but one less thing to consider when actually doing to
work of unraveling ttconv (per #3135 (comment)).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Kojoley
Kojoley reviewed Jan 4, 2020
View reviewed changes
Copy link
Member

@Kojoley Kojoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change in_string type from int to bool then? (Even though the variable declaration does not have static specifier I cannot find references from other places, so it should not break anything).

@anntzer
Use C++ true/false in ttconv.
634c6f0 
Not much to it, but one less thing to consider when actually doing to
work of unraveling ttconv.
@anntzer
Copy link
Contributor Author

anntzer commented Jan 4, 2020

sure, done

@Kojoley Kojoley added this to the v3.3.0 milestone Jan 4, 2020
@Kojoley Kojoley merged commit b459bc7 into matplotlib:master Jan 4, 2020
@anntzer anntzer deleted the ttconv branch January 4, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kojoley Kojoley Kojoley approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: text/fonts
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @Kojoley @timhoffm