Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix more missing references again. #16125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 6, 2020

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the morerefs branch 3 times, most recently from ff69135 to 12c25da Compare January 7, 2020 09:40
@Kojoley Kojoley added this to the v3.1.3 milestone Jan 8, 2020
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor nits. May self merge after resolving.

@anntzer anntzer merged commit 4130dab into matplotlib:master Jan 9, 2020
@anntzer anntzer deleted the morerefs branch January 9, 2020 15:16
@lumberbot-app
Copy link

lumberbot-app bot commented Jan 9, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 4130dabbc13a2ae9f29e13684018aac0a583dc79
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16125: Fix more missing references again.'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-16125-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #16125 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 9, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 4130dabbc13a2ae9f29e13684018aac0a583dc79
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16125: Fix more missing references again.'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-16125-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #16125 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@timhoffm
Copy link
Member

timhoffm commented Jan 9, 2020

I think the point where we could reasonably backport documentation changes to 3.2 or 3.1 has passed because we've had too many documentation changes recently (which is a good thing!).

@QuLogic QuLogic modified the milestones: v3.1.3, v3.3.0 Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants