-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: reword density desc in ax.hist
#16149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm +0 for changing "sum" into "integrate". I'm +1 on showing the formula, however, it should use the nomenclature of the return (which currently is I'm -1 on deleting the sentence on how the density is computed; although it could of course be reformulated to be less ambiguous. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it's better.
Edit: I also agree with Ernest's comments :)
I don't see that the "how" its computed really makes things clearer. For reference, here is numpy's doc:
https://docs.scipy.org/doc/numpy/reference/generated/numpy.histogram.html |
2d63baf
to
6c3d269
Compare
6c3d269
to
115348f
Compare
OK< changed to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Thanks @jklymak ! |
PR Summary
Changed the docstring of the
density
kwarg to be a little clearer and to avoid the phrase "sum to 1" , which a quick read could make one think the histogram should sum to 1.Closes #16147 (?)
PR Checklist