Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make Animation.repeat_delay an int, not an int-or-None. #16227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

Make Animation.repeat_delay an int, not an int-or-None. #16227

merged 1 commit into from
Jan 16, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 14, 2020 •
edited
Loading

PR Summary

I didn't bother going through a deprecation in case someone was really
explicitly passing None... (i.e. I left the backcompat)

Suggested in #16218 (comment); goes on top of #16218 (edit: which has now been merged).

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Jan 14, 2020
@anntzer
Make Animation.repeat_delay an int, not an int-or-None.
1b74c44 
I didn't bother going through a deprecation in case someone was really
explicitly passing None...  (i.e. I left the backcompat)
@dopplershift dopplershift merged commit f9bf67a into matplotlib:master Jan 16, 2020
@anntzer anntzer deleted the animrdelay branch January 16, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: animation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @dopplershift @timhoffm