TST: move the Qt-specific handling to conftest #16261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
Jan 19, 2020
|
Tried re-basing to pick up the scipy related doc fix and see if that fixes the azure + windows + git clone related issues. |
The order fixtures are applied appears to have changed / become indeterminate in pytest 5.3.3 which breaks the over-riding of mpl_test_settings that we were doing in test_backend_qt5. This moves the skipping logic to mpl_test_settings, but leaves the importing of QtCore in the qt_core fixture.
3d8a6cb to
44a92d5
Compare
timhoffm
approved these changes
Jan 23, 2020
anntzer
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order fixtures are applied appears to have changed / become
indeterminate in pytest 5.3.3 which breaks the over-riding of
mpl_test_settings that we were doing in test_backend_qt5.
This moves the skipping logic to mpl_test_settings, but leaves the
importing of QtCore in the qt_core fixture.
This is a follow on to #16259 that should work for all versions of pytest.