Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prefer using MouseButton to numeric values in docs and defaults. #16277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2020
Merged

Prefer using MouseButton to numeric values in docs and defaults. #16277

merged 1 commit into from
Jan 21, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 21, 2020

They are more self-explanatory (and completely backcompatible, as they
inherit from int).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Prefer using MouseButton to numeric values in docs and defaults.
786892b 
They are more self-explanatory (and completely backcompatible, as they
inherit from int).
@dstansby dstansby added this to the v3.2.0 milestone Jan 21, 2020
@timhoffm timhoffm merged commit e3e7792 into matplotlib:master Jan 21, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Jan 21, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 e3e7792a5b52124dc8f8feab463724c00db89f83
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16277: Prefer using MouseButton to numeric values in docs and defaults.'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-16277-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #16277 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the mousebuttondocs branch January 21, 2020 21:19
@tacaswell tacaswell modified the milestones: v3.2.0, v3.3.0 Feb 16, 2020
@tacaswell
Copy link
Member

This does not seem critical to back-port, remilestoning to 3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @timhoffm @dstansby