Don't recursively call draw_idle when updating artists at draw time. #16298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Jan 23, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 27, 2020
…pdating artists at draw time.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 27, 2020
…pdating artists at draw time.
|
This issue only shows up at a plain python prompt but not in IPython due to the different ways the auto-re-draw is implemented. In IPython, we install a hook to run right before we give control back to the user, in plain python we trigger the draw_idle immediately on a figure going stale. |
tacaswell
added a commit
that referenced
this pull request
Jan 27, 2020
…298-on-v3.1.x Backport PR #16298 on branch v3.1.x (Don't recursively call draw_idle when updating artists at draw time.)
tacaswell
added a commit
that referenced
this pull request
Jan 27, 2020
…298-on-v3.2.x Backport PR #16298 on branch v3.2.x (Don't recursively call draw_idle when updating artists at draw time.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #16294, AFAICT. I think this basically arose from the combination of #10210 not including the fix at #16028, plus #9082 whose review period overlapped with #10210.
Also needs to be backported to 3.2.
PR Checklist