Dedupe Legend.draw_frame which is the same as set_frame_on. #16303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't care enough to bother deprecating it, but maintaining a separate (in fact, slightly different) docstring and having it count against coverage seems a bit silly. I left set_frame_on be the "canonical" version as there's also get_frame_on.
dstansby
approved these changes
Jan 23, 2020
jklymak
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't care enough to bother deprecating it, but maintaining a separate
(in fact, slightly different) docstring and having it count against
coverage seems a bit silly.
I left set_frame_on be the "canonical" version as there's also
get_frame_on.
PR Summary
PR Checklist